Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just prevent TypeError: Cannot read property 'constructor' of undefined #235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jasonxia23
Copy link

Just prevent TypeError: Cannot read property 'constructor' of undefined

@coveralls
Copy link

coveralls commented Sep 18, 2016

Coverage Status

Coverage remained the same at 93.617% when pulling c7a989e on jasonxia23:master into 531cb12 on huei90:master.

@liorcode
Copy link
Contributor

liorcode commented Sep 25, 2016

please update both the sources and create the dist and minified dist files using the build task and squash your commits.

But I actually think the solution should be in the checkValidation function itself.. I think it should always return either error or success, never undefined. This is my proposal: #241

@hueitan
Copy link
Owner

hueitan commented Oct 14, 2016

yes, there is no undefined return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants